Skip to content

Engineering team fixes - #1596

Open
d215steinberg wants to merge 5 commits into
ed-donner:mainfrom
d215steinberg:engineering_team_fixes
Open

Engineering team fixes#1596
d215steinberg wants to merge 5 commits into
ed-donner:mainfrom
d215steinberg:engineering_team_fixes

Conversation

@d215steinberg

Copy link
Copy Markdown
  1. Beefed up agent and task definitions to prevent backend_agent from writing front-end code and unit tests.
  2. Explicitly specify UTF-8 encoding (not the default for Windows - Green check and red x were not showing up
  3. Append stderr to test output and specify that output consists of just the test summary (previously, test_summary.md contained the test code.
  4. Exclude Docker's .venv from the bind-mounted sandbox to prevent Windows-hostile Linux symlinks from seeping in.
  5. Remove Sandbox directory on error for Windows to prevent starting up with corrupt sandbox
  6. Specify no-sync on uv add gradio when resetting Sandbox to prevent Windows lockout.

…t output. Unicode characters supported for Windows. Sanbox reset hardened for Windows. venv excluded from bind-mounted directory (problematic for Windows).
@ed-donner

Copy link
Copy Markdown
Owner

Hey,
I'm super grateful that you've worked on this and are sharing your contribution. It looks like this might not be ready to be merged - please can I ask you to review this:

https://edwarddonner.com/pr

The most common issue is that you've included a file outside community-contributions. This would impact all students on the course. You can see this by going to the "Files changed" tab in this PR; the only changes should be to files in community-contributions.

If there's a good reason to change files outside community-contributions, like an important bug fix, then please let me know (and thank you!)

The 2nd most common reason is that you've not cleared outputs of Notebooks, leading to large code changes. Instructions at the link above.

The 3rd common reason is that you've included too many changes, such as many thousands of lines of code, or a large number of files. I'm grateful for your work, but see the link above for ways we can include this without the repo getting too large.

The PR details in this Github screen shows you the files changed, and at the top right the number of lines added (in Green) and deleted (in Red) by this PR. Typically the Green number should be less than 2,000 and the red number should be 0.

I very much look forward to merging when this is addressed. Thanks so much
Ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants